Warn when a proposer settings file replaces per-key settings saved in the DB - #17455
Open
syjn99 wants to merge 1 commit into
Open
Warn when a proposer settings file replaces per-key settings saved in the DB#17455syjn99 wants to merge 1 commit into
syjn99 wants to merge 1 commit into
Conversation
… the DB selectProposerConfig lets a --proposer-settings-file/-url per-key section replace the DB's per-key section entirely, so fee recipients, gas limits, graffiti or builder configs written through the keymanager API since the last restart vanish with only "Proposer settings loaded from file" in the log. Logging only, no behavior change: after the merge, compare the normalized settings against what the DB held and warn once with the dropped and overridden keys (capped at 10 with a "+N more" tail). Comparing normalized settings rather than raw payloads keeps an unchanged restart quiet, including v1 setups where --enable-builder fills in per-key builder content. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
syjn99
commented
Sep 4, 2026
| for _, tt := range tests { | ||
| for _, isSlashingProtectionMinimal := range [...]bool{false, true} { | ||
| t.Run(fmt.Sprintf("%v-minimal:%v", tt.name, isSlashingProtectionMinimal), func(t *testing.T) { | ||
| hook.Reset() |
Member
Author
There was a problem hiding this comment.
This is needed for running the tests multiple times in this unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
selectProposerConfiglets a--proposer-settings-file/-urlper-key section replace the DB's per-key section entirely, so fee recipients, gas limits, graffiti or builder configs written through the keymanager API since the last restart vanish with only "Proposer settings loaded from file" in the log.This is because we're consolidating all changes at startup and in the runtime in our DB, and I believe this needs fundamental restructure on this. However, given the complexity for revamping the loader, I'd rather log and say it loud to users. After the merge, it compares the normalized settings against what the DB held and warn once with the dropped and overridden keys (capped at 10 with a "+N more" tail).
Which issue(s) does this PR fix?
N/A
Other notes for review
Acknowledgements